Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine2): ensure static files are up to the tip when coming from an old engine node #10299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(engine2): ensure static files are up to the tip when coming from an old engine node #10299

wants to merge 1 commit into from
+3 −0

Conversation

joshieDo
Copy link
Collaborator

closes #10268

The new engine writes directly to static files, so we need to make sure that they're up to the tip when coming from an old engine node.

@joshieDo joshieDo added C-bug An unexpected or incorrect behavior A-static-files Related to static files labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-static-files Related to static files C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnexpectedStaticFileBlockNumber Error Using Engine2
2 participants
@joshieDo @shekhirin