Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more granular tx propagation logs #10026

Merged
merged 1 commit into from
Aug 2, 2024
Merged

feat: add more granular tx propagation logs #10026

merged 1 commit into from
Aug 2, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Aug 2, 2024

This adds some logs related to transaction gossip, with the target net::tx::propagation. This is useful for tracking down which transactions we're sending to peers and when we're receiving those transactions from peers.

@Rjected Rjected added C-enhancement New feature or request A-tx-pool Related to the transaction mempool A-observability Related to tracing, metrics, logs and other observability tools labels Aug 2, 2024
mattsse
mattsse approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be incredibly noisy, but for debugging should be okay, although these will now appear on the net level

@Rjected Rjected added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit a6733ca Aug 2, 2024
33 checks passed
@Rjected Rjected deleted the dan/granular-propagation-logs branch August 2, 2024 16:27
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
@Rjected @martinezjorge
feat: add more granular tx propagation logs (paradigmxyz#10026)
ab3589c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rjected @mattsse