Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better tree observability #10014

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 2, 2024

towards #10007

adds a few more traces to the downloading logic and adds a fix that includes downloaded blocks

needs more scenario testing in followups

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Aug 2, 2024
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mattsse mattsse added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit ae4be80 Aug 2, 2024
33 checks passed
@mattsse mattsse deleted the matt/tree-obs-and-connect-buffers branch August 2, 2024 11:27
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants