Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit tests for pg_search #573

Merged
merged 13 commits into from
Dec 4, 2023
Merged

Conversation

Lilit0x
Copy link
Contributor

@Lilit0x Lilit0x commented Nov 28, 2023

Ticket(s) Closed

What

Unit Tests for pg_search

Why

Adding unit test suites to pg_search to increase the code coverage

How

Tests

Copy link

vercel bot commented Nov 28, 2023

@Lilit0x is attempting to deploy a commit to the ParadeDB Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
paradedb ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 6:15pm

@philippemnoel
Copy link
Collaborator

philippemnoel commented Nov 30, 2023

@Lilit0x there were some issues in how we ran pg_search tests in CI. I fixed them in #588. If you rebase on dev, you should be good to keep going.

pg_search/src/api.rs Outdated Show resolved Hide resolved
pg_search/src/api.rs Outdated Show resolved Hide resolved
@Lilit0x
Copy link
Contributor Author

Lilit0x commented Dec 4, 2023

@philippemnoel, is there anything else I need to do to run the tests for pg_search? I have installed the pg_vector extension manually also, but I keep getting this error:

There was an issue creating the extension 'pg_search' in Postgres:

Caused by:
    ERROR SQLSTATE[0A000]: extension "vector" is not available
    query: CREATE EXTENSION pg_search CASCADE;
    params: None

@philippemnoel
Copy link
Collaborator

@philippemnoel, is there anything else I need to do to run the tests for pg_search? I have installed the pg_vector extension manually also, but I keep getting this error:

There was an issue creating the extension 'pg_search' in Postgres:

Caused by:
    ERROR SQLSTATE[0A000]: extension "vector" is not available
    query: CREATE EXTENSION pg_search CASCADE;
    params: None

You need to run ./configure.sh

@Lilit0x
Copy link
Contributor Author

Lilit0x commented Dec 4, 2023

You need to run ./configure.sh

Thanks!

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #573 (37cc28a) into dev (322d272) will decrease coverage by 30.22%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #573       +/-   ##
===========================================
- Coverage   80.61%   50.40%   -30.22%     
===========================================
  Files          30       29        -1     
  Lines        3663     2706      -957     
===========================================
- Hits         2953     1364     -1589     
- Misses        710     1342      +632     
Files Coverage Δ
pg_search/src/api.rs 96.20% <100.00%> (+96.20%) ⬆️

... and 23 files with indirect coverage changes

@Lilit0x Lilit0x marked this pull request as ready for review December 4, 2023 17:57
pg_search/src/api.rs Outdated Show resolved Hide resolved
pg_search/src/api.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@philippemnoel philippemnoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@philippemnoel philippemnoel merged commit 0b69d82 into paradedb:dev Dec 4, 2023
12 checks passed
@philippemnoel
Copy link
Collaborator

Thank you for doing this, always amazing seeing your contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write unit & regression tests for pg_bm25 and pg_search
2 participants