Use system memlock limit to set the secure memory pool size #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Gcrypt's secure memory, the amount of needed memory must be greater than the current memlock OS limit (ulimit -l). On some systems, this value is very low (64 KB), thus causing the software to not even start up. A few possibilities were evaluated: 1. use setcap on installation phase: easy, but not achievable with flatpak, appimage, and Co. 2. force the user to play with ulimit: cumbersome and absolutely not user-friendly 3. set the max available secure memory to the current system memlock value Option 3 is the one that got implemented with this commit. This has a small drawback though because if a user needs to store more than ~130 tokens, each one using very long (128 chars) label and issuer and long (64 chars) secret, the user won't be able to do that, unless he/she does something with either setcap or ulimit. - fix #31 - update readme - show a warning when memlock limit is less than 256KB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.