Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto lock and secret service should be mutually exclusive #279

Closed
paolostivanin opened this issue Jan 17, 2023 · 0 comments · Fixed by #282
Closed

auto lock and secret service should be mutually exclusive #279

paolostivanin opened this issue Jan 17, 2023 · 0 comments · Fixed by #282
Assignees
Milestone

Comments

@paolostivanin
Copy link
Owner

paolostivanin commented Jan 17, 2023

I recently upgraded from 2.4.x to 3.1.x, read about the new Secret service integration feature, left it on, and was surprised to see I got:

  1. No password at startup ...
  2. ... but got asked for a password after an Auto lock (because I was migrated from a 2.4 with Auto Lock options on) ...
  3. ... which was defeated by simply restarting the app!

→ What's the point of enabling options Auto lock on system lock and Auto lock when inactive for ... if all you have to do to unlock the app is to restart it?!

Said differently, it feels like options Auto lock vs. Secret service integration are mutually exclusive:

  1. The app should GTK-disable the two Auto lock options ("grey them out") when the Secret service feature is enabled. Rationale: the lock is meaningless security-wise if you have Secret service integration, and only adds bogus friction.
  2. The app should GTK-disable Secret service integration if one of the two Auto lock options are enabled. Rationale: if you use Auto lock, then you want control over when to lock/unlock, and you want to be prompted at startup.

Does that make sense? Am I missing something?

Originally posted by @ronjouch in #264 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant