Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/cloudflare worker jwks fetch #257

Closed

Conversation

OwenDelahoy
Copy link

@OwenDelahoy OwenDelahoy commented Sep 2, 2021

Sorry I didn't realize github actions would close my previous PR #255

Based on your feeback I created an alternative which detects support for each property

const hasMode = ("mode" in new Request(""))
const hasCredentials = ("credentials" in new Request(""))
const hasReferrerPolicy = ("referrerPolicy" in new Request(""))

I have tested this inside cloudflare workers and it works as expected.

@panva
Copy link
Owner

panva commented Sep 2, 2021

I've created a fix and released it already https://github.com/panva/jose/releases/tag/v3.15.5

@panva panva closed this Sep 2, 2021
@OwenDelahoy
Copy link
Author

OwenDelahoy commented Sep 2, 2021

I am disappointed that after the hours I spent tracking down this bug, fixing your build scripts to run on linux, submitting a PR, testing, and then adjusting it based on your feedback, my contribution was not included.

I am unlikely to attempt contributing again.

@panva
Copy link
Owner

panva commented Sep 2, 2021

My apologies. Nevertheless thank you again for bringing the issue out and your suggestions.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants