-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlisted dependency on assert
in the browser
#206
Labels
bug
Something isn't working
Comments
The intention is to not have a dependency, this is an oversight i'll get fixed. |
Quick as usual - thanks! |
Vinnl
added a commit
to inrupt/jose-legacy-modules-js
that referenced
this issue
Jun 2, 2021
Filip released a fix in upstream jose: panva/jose#206 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
No dependencies are listed in
package.json
, however, the browser package appears to depend onassert
.To Reproduce
See https://unpkg.com/browse/[email protected]/dist/browser/util/decode_protected_header.js
There's a non-relative import on the first line:
If the
assert
npm module is not present, this will not resolve.Expected behaviour
Either for there to not be a dependency on
assert
, or forassert
to be listed as a dependency inpackage.json
.Environment:
jose
version: 3.12.2Additional context
jose
too. - looks like itThe text was updated successfully, but these errors were encountered: