Changed max lenght of email address #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wether or not this is the proper way to do it, you could also add a check within validateUserEmail, which would limit to 64 chars. |
|
Hi, big thanks! This project has reached End Of Life, so it's not developed anymore, but i'll will merge this anyway as it's a small and nice chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to suggest changing the max lenght of the email field in the database.
Since its provided in this stackoverflow post that emails can at max be 254 chars long.
After checking against the local php filter in the Registratonmoddel::validateUserEmail() we do not check the length of the email before its added to the database. (which could result in a failed user creation without giving back a proper error.)