Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: DB User & Password shown in clear text in error message #763

Merged
merged 3 commits into from
Dec 19, 2015

Conversation

slaveek
Copy link
Contributor

@slaveek slaveek commented Dec 19, 2015

Fix for: #760 issue by @JFJanssen

slaveek and others added 3 commits December 14, 2015 19:03
Develop update from head fork
Check DB connection in try/catch block. Also when PDO is not constructed
properly, prevent to exposing database host, username and password in
plain text as:
PDO->__construct('mysql:host=127....', 'root', '12345678', Array)
by throwing custom error message
Convert indentation to spaces.
@panique
Copy link
Owner

panique commented Dec 19, 2015

Excellent, thanks a lot ! :)

panique added a commit that referenced this pull request Dec 19, 2015
FIX: DB User & Password shown in clear text in error message
@panique panique merged commit 7b4ca9c into panique:develop Dec 19, 2015
@slaveek slaveek deleted the develop branch December 20, 2015 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants