Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clarifying] Prevent unwanted redirects #695

Closed
wants to merge 1 commit into from
Closed

[clarifying] Prevent unwanted redirects #695

wants to merge 1 commit into from

Conversation

jbonnett92
Copy link

More accurately redirects... If there is a HTTP_REFERER available.

More accurately redirects... If there is a HTTP_REFERER available.
@panique
Copy link
Owner

panique commented Aug 16, 2015

Thanks, but can you please comment what exactly this does and why it's an advantage to the current code ?

@panique panique changed the title Prevent unwanted redirects [clarifying] Prevent unwanted redirects Aug 16, 2015
@panique
Copy link
Owner

panique commented Sep 7, 2015

Thank you for this commit, I'll put this pull request on ice for a while until there's time for proper testing and good documentation, as I'm currently I'm not 100% sure what the code does.

As this is a security-critical framework it's necessary to only accept pull requests that are 100% transparent and easy to understand. I hope that's okay for you :)

@panique panique closed this Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants