[testing] Added changePassword Page #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 27, 2015 15:52
Added a changePassword Page so logged in users can change their password (if they know the current password) Renamed some previous functions to make it more clear they are for the resetPassword page, not the changePassword page
Forgot to add this on the last commit (whoops) Just a link to the changePassword page on the header if a user is logged in
(Whoops) left in a line which printed out the password hash on error (I did this during writing to make sure the hash was making it to this point)
added 6 commits
August 5, 2015 10:22
Removed _action from some function names I made that didn't need it (because they're not specifically for form submit) Also changed returning of some functions, to make sure they can show more than one error at once (e.g. username is taken and email is taken, before this would require one field to be fixed before seeing the other error) Removed a link from changePassword page (it was there for resetPassword and is no longer needed)
Replaced hidden input for username and just get username directly in the changePassword_action function
Renamed header for resetPassword
Fixed an error where the registerNewUser() function returned too early
Regenerate Session ID on password change
Turns out it logs you out if you do this, I'll let someone else figure out how to regenerate session id without logging out
|
Thanks, I'll test this for a while and then merge it |
panique
changed the title
panique
added a commit
that referenced
this pull request
Sep 7, 2015
PR #689 : added password change feature
|
Thank you very much, it's tested and merged, works very fine! I'll add your name to the changelog for sure. |
|
Great! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a changePassword page so a logged in user can change their password (if they know the current password)
I thought this would be within the scope of 'basic functionality' for HUGE so I decided to fork it and add it in, since I need it for what I'm using it for anyway
I'm fairly novice PHP programmer so there might be a better way of doing some things but I followed the format of the previous functions and comments as much as I could
I also renamed some old functions to make it clear they were for resetPassword, not changePassword
Finally I added the page to the header for easy navigation
Hope you like!