Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brute force attack mitigation #669

Closed
wants to merge 2 commits into from
Closed

Conversation

sandropons
Copy link

hello,
i've added a basic control to mitigate brute force login attempts to check against users in database.

basic control for brute force attack mitigation
login failed message for brute force mitigation
@panique
Copy link
Owner

panique commented Jun 30, 2015

Thanks, but isn't exactly this already implemented ? Can you please have a look here:
https://github.com/panique/huge/blob/master/application/model/LoginModel.php#L77

@sandropons
Copy link
Author

Hi,
The one already implemented does block login attempts only for found usernames.

A brute force attack can do unlimited logins attempts to guess usernames without any limit.

I've just placed a limit of 3 attempts and 30 second interval for that.

Hope it's useful.
Cheers,
Sandro

panique added a commit that referenced this pull request Jul 9, 2015
@panique
Copy link
Owner

panique commented Jul 9, 2015

Hey, I've added this to the project, but as you've pushed to master branch (needs to be pushed to develop branch) I had to move your commit via a patch. This has unfortunatly removed your name as the author of these lines (and replaced it with mine)... Hmm... Sorry for that! If it's important for you, then you can resubmit this to develop branch!

Thanks again and have a great day!

@panique panique closed this Jul 9, 2015
panique added a commit that referenced this pull request Jul 9, 2015
@sandropons
Copy link
Author

Hi, no problem with that, thanks to you for the cool project!

Cheers,
Sandro

2015-07-09 4:07 GMT+02:00 Chris [email protected]:

Hey, I've added this to the project, but as you've pushed to master branch
(needs to be pushed to develop branch) I had to move your commit via a
patch. This has unfortunatly removed your name as the author of these lines
(and replaced it with mine)... Hmm... Sorry for that! If it's important for
you, then you can resubmit this to develop branch!

Thanks again and have a great day!


Reply to this email directly or view it on GitHub
#669 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants