Update login_model.php #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proposed change to fix facebook registration if the cleaned facebook username already exists... the generateUniqueUserNameFromExistingUserName function should also be useful for clashes when twitter / google plus registration is added
|
Btw your commit is placed perfectly! Everything right here! I just haven'd had the time for testing. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposed change to fix facebook registration if the cleaned facebook username already exists...
the generateUniqueUserNameFromExistingUserName function should also be useful for clashes when twitter / google plus registration is added
P.S. It's my first time on git hub, apologies if this isn't the correct way to add a suggestion.