Update Model.php #315
Closed
Update Model.php #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it looks like it is possible to use multiple db connection in one single request, instead of reusing the PDO class instance. This ensure to use instantiate one single time the Database.
|
Hey, please take a look at the develop branch. The whole script was refactored and Model.php no longer exists. |
|
Thanks @Yacine-krk , but this (or something similar) has already been done in the develop branch. Please never push into master branch, as the master always contains a stable release. The develop branch holds the in-development version. Currently the entire script collection gets a massive makeover, therefore a lot of things will change. Sorry, normally I would thankfully merge your commit, but i this case it's not possible :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it looks like it is possible to use multiple db connection in one single request, instead of reusing the PDO class instance.
This ensure to use instantiate one single time the Database.