Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to include php-login in an existant website & add option to turn off public register. #31

Closed
wants to merge 23 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 31, 2013

I have adapted it to the way i use it without breaking the views. Next, security feature.(will be buld over this pull request).

@ghost
Copy link
Author

ghost commented Feb 18, 2013

Plz Panique, at least, tell me that you won't accept it.

@panique
Copy link
Owner

panique commented Feb 19, 2013

Hey, just haven't seen this yet. I will have a look on that code in the next few days. Thanks!

@ghost
Copy link
Author

ghost commented Mar 25, 2013

Hi Panique, i have change near 500 line of code now :D I feel pretty far from your code. I know you are working on the next version but i d'ont see it.

Unfortunately, i got my deadlines and shits. So, shoud i wait to see what will happend with my code and implement gettext on the next version or just do it on my fork over my stuff ?
(personally i hate projects forks)

@panique
Copy link
Owner

panique commented Mar 25, 2013

Hey, thanks for that, but i haven't looked on your code yet. I think it's far from how my version looks like and some general aspect are completely different now (way of including etc). I would say you should make a fork / own version, as merging this would result in a bad version, instead of 2 quite good ones. anyway, thanks for your time on this!

@ghost
Copy link
Author

ghost commented Apr 2, 2013

i don't like project forking and i dont have the energy to maintain a fork of PHP-login. But i think you're right. There some inconsistance that i can't figure to fix without rewrithing everything.

If you're on to give a try, let me know :D

@panique panique closed this Apr 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants