Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed those ugly array phplogin_lang keys #306

Closed
wants to merge 2 commits into from
Closed

Fixed those ugly array phplogin_lang keys #306

wants to merge 2 commits into from

Conversation

seromenho
Copy link
Contributor

No description provided.

They should look like "database_error", not "Database error"
@panique
Copy link
Owner

panique commented Dec 8, 2013

Hey, thanks, but 1.) please always commit into the DEVELOP branch, never into the master (which always contains the stable version), 2.) currently the entire project is in a total-rewriting-process (see develop branch), so maybe your changes do not fit anymore...

Can you resubmit this into develop branch please ? Thnaks a lot!

@seromenho
Copy link
Contributor Author

Ok.
Have resubmitted into develop branch

Cumprimentos,
Ricardo Seromenho

On 8 December 2013 16:50, panique [email protected] wrote:

Hey, thanks, but 1.) please always commit into the DEVELOP branch, never
into the master (which always contains the stable version), 2.) currently
the entire project is in a total-rewriting-process (see develop branch), so
maybe your changes do not fit anymore...

Can you resubmit this into develop branch please ? Thnaks a lot!


Reply to this email directly or view it on GitHubhttps://github.com//pull/306#issuecomment-30085397
.

@seromenho
Copy link
Contributor Author

Cancel this

@seromenho seromenho closed this Dec 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants