Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multilanguage support for 2-Advanced #214

Merged
merged 13 commits into from
Sep 1, 2013
Merged

Conversation

devplanete
Copy link
Contributor

Add lang folder with translation file for English and French.
You can simply add new language by translating content of the "lang\en.php" into another language.

In php-login.php, I have added a function to detect user language and to load the translation file if available (english otherwise).

I have modify all the views files to have a HTML header (because utf8 characteres are not well displayed without utf8 header).
I have removed php-login pub from generated html. For security purpose, it's not a good idea to show the login script that you web site is using...
I have merge password_reset_new_password.php and password_reset_request.php into only one file password_reset.php

@panique
Copy link
Owner

panique commented Sep 1, 2013

Once again, good stuff! But I think those tranlation string should be constants, not variables. I'm not sure here, but a variable can change during app runtime, a constant always stays the same. But a lots of similar-named constants might look strange... Hmmm... I will read into the topic a little bit more.

Also, I totally agree that to remove the script naming in the views!

Big thanks.

By the way @devplanete, are you french/canadian and a native speaker ? (I have a french-sounding avatar name, but only speak a little bit french, far away from being able to check french translations ;) )

panique added a commit that referenced this pull request Sep 1, 2013
Add multilanguage support for 2-Advanced
@panique panique merged commit 9796908 into panique:develop Sep 1, 2013
@devplanete
Copy link
Contributor Author

@panique I'm french from France so I think that my translations are good ;)

I always use a simple php array to store translation strings. I don't know if it will be a real difference for php if we use constants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants