Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register IF statement - Take 2 #201

Closed
wants to merge 2 commits into from
Closed

Conversation

AmyStephen
Copy link

OK, here's another try =)

I split up the IF statement into single IF statements, and thanks to Davey Shafik, this time I created a little edit function so that I could return on the first error found, thus (really) not changing the logic like I claimed last time.

Thanks!

@panique
Copy link
Owner

panique commented Aug 27, 2013

Thanks a lot Amy, can you please re-commit this into the develop branch ? I cannot (= dont want ;) ) merge directly into master. Big Thanks, you just fixed the internet a little bit tonight, some people got heart attacks because of that if/else stack.

@panique panique closed this Aug 27, 2013
@krolow
Copy link

krolow commented Aug 27, 2013

why leave the else conditions would not be better to just leave the if's as a negative condition?

@panique
Copy link
Owner

panique commented Aug 27, 2013

This has been a discussion before: "negative-first decisions are bad" is the conclusion afaik. But correct me if i'm wrong. @AmyStephen , what do you say ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants