Develop #191
Merged
Develop #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace mysqli functions by PHP PDO functions in all database calls. Replace all direct calls to "new mysqli(DB_HOST, DB_USER, DB_PASS, DB_NAME)" by the function "private function databaseConnection()" This function check if database connection already opened, create connection if needed and return true or false (if false, error message is added to error string of the class)
… by controller/action/model, exactly like it should be ;)
… folder needs to be checked)
Replace mysqli functions by PHP PDO functions in all database calls.
Update Registration.php : PDO support
Update Login.php - PDO support
I have cleaned codes and refactored the class with an eye on PSR-0/1/2 code conventions
Update Registration.php - Code cleaned & refactored with PSR-0/1/2 code conventions
…e from being downloaded
…event SQLite database file from being downloaded and blocked folder access
…event SQLite database file from being downloaded and blocked folder access
Improve Remember Me cookie feature and security
replace direct calls to database to look for user data by a new function getUserData (it's improve code lisibility and maintenance) added some comments to explain new internal functions
Update login.php Add new function getUserData and comments
…file / readme fixes
Rather than directly use $_POST and $_GET inside functions of the class, I have added some parameters to class functions. It's far more easy to know now input data needed by each functions - registerNewUser($user_name, $user_email, $user_password, $user_password_repeat, $captcha) - verifyNewUser($user_id, $user_activation_hash) - sendVerificationEmail($user_id, $user_email, $user_activation_hash) Some private variables have been removed because not use anymore. At user creation, I record inside database the current datetime and the ip address used
Registration.php - code improvement
Registration.php update for compatibility with Mysql 5.0
panique
added a commit
that referenced
this pull request
Aug 25, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.