Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail.sendphpmail always returns true #729

Closed
1010101110 opened this issue Sep 22, 2015 · 2 comments
Closed

mail.sendphpmail always returns true #729

1010101110 opened this issue Sep 22, 2015 · 2 comments

Comments

@1010101110
Copy link

application/core/Mail.php

line: 87 and 89

description: for some reason we aren't saving return code from the mail send function, this means it always returns true (even when send mail fails). current code checks if mail object is still alive for some reason? php mailer returns true / false we should use that!

proposed fix1 or 2:
fix

oh or move the call into the if(), so we get return value, eitherway

@1010101110 1010101110 changed the title mail.sendphpmail return not being set mail.sendphpmail always returns true Sep 22, 2015
@panique
Copy link
Owner

panique commented Sep 22, 2015

Good point! Fix coming up!

panique added a commit that referenced this issue Oct 4, 2015
FIX for #729: mail sending now returns true or false
@panique
Copy link
Owner

panique commented Oct 4, 2015

Thanks, it's now fixed in develop and master branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants