-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mail.sendphpmail always returns true #729
Comments
Good point! Fix coming up! |
panique
added a commit
that referenced
this issue
Oct 4, 2015
panique
added a commit
that referenced
this issue
Oct 4, 2015
panique
added a commit
that referenced
this issue
Oct 4, 2015
FIX for #729: mail sending now returns true or false
Thanks, it's now fixed in develop and master branch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
application/core/Mail.php
line: 87 and 89
description: for some reason we aren't saving return code from the mail send function, this means it always returns true (even when send mail fails). current code checks if mail object is still alive for some reason? php mailer returns true / false we should use that!
proposed fix1 or 2:
![fix](https://camo.githubusercontent.com/19a2d45995eb5a71665fcd43d5d374f4d443254636fb1933edbc76c066bfbcca/687474703a2f2f692e696d6775722e636f6d2f706378393057522e706e67)
oh or move the call into the if(), so we get return value, eitherway
The text was updated successfully, but these errors were encountered: