Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Check network URL statuses in tests #45949

Merged
merged 6 commits into from
Feb 15, 2022

Conversation

mroeschke
Copy link
Member

This run failed because a test that hit a url was able to download content but the page displayed a 404 page

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=73924&view=logs&jobId=054c7612-f473-5cf0-0a65-77b54574553a&j=054c7612-f473-5cf0-0a65-77b54574553a&t=7218990d-7c28-52cc-5797-2fee2b0645b4

Checking more urls in our test suite and the response status.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite IO Network Local or Cloud (AWS, GCS, etc.) IO Issues labels Feb 12, 2022
@mroeschke mroeschke added this to the 1.5 milestone Feb 13, 2022
@jreback jreback modified the milestones: 1.5, 1.4.2 Feb 13, 2022
@jreback
Copy link
Contributor

jreback commented Feb 13, 2022

any reason we shouldn't backport?

@mroeschke
Copy link
Member Author

any reason we shouldn't backport?

Fair, this would help the tests in 1.4.x

@jreback jreback merged commit 4bc68b3 into pandas-dev:main Feb 15, 2022
@jreback
Copy link
Contributor

jreback commented Feb 15, 2022

@meeseeksdev backport 1.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented Feb 15, 2022

Something went wrong ... Please have a look at my logs.

@mroeschke mroeschke deleted the tst/network_url branch February 15, 2022 01:21
phofl pushed a commit that referenced this pull request Feb 15, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Network Local or Cloud (AWS, GCS, etc.) IO Issues Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants