Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Jinja2 requirements #3155

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Bump Jinja2 requirements #3155

merged 1 commit into from
Apr 15, 2019

Conversation

zabbal
Copy link

@zabbal zabbal commented Apr 15, 2019

The 2.10.1 version was released 2019-04-06 and contains important security fix.
This change allows flask users to avoid implicit insecure dependency.

@ThiefMaster
Copy link
Member

I disagree that this is an "important" security fix in this context, since Flask does not use Jinja's SandboxedEnvironment and thus the fix doesn't apply.

But I guess it's a good idea to bump the dependency anyway, even if it's just to avoid warnings from GitHub's dependency security checker.

The 2.10.1 version was released 2019-04-06 and contains important security fix.
This change allows flask users to avoid implicit insecure dependency.
@zabbal
Copy link
Author

zabbal commented Apr 15, 2019

I agree that it's unimportant for Flask, the "important security fix" is referring to Jinja2 version.

@davidism davidism merged commit c5c8bbc into pallets:master Apr 15, 2019
Ez1o0 added a commit to Ez1o0/flask that referenced this pull request May 26, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants