Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix some typos in config.rst #2918

Merged
merged 1 commit into from
Jan 6, 2019

Conversation

garenchan
Copy link
Contributor

@garenchan garenchan commented Sep 21, 2018

Fix some typos in config.rst

@garenchan garenchan closed this Sep 21, 2018
@garenchan garenchan reopened this Sep 21, 2018
docs/config.rst Outdated Show resolved Hide resolved
docs/config.rst Outdated Show resolved Hide resolved
@davidism
Copy link
Member

davidism commented Sep 21, 2018

Please make docs changes against 1.0-maintenance (unless they have to do with new features). Otherwise the changes will only appear in the dev version of the docs.

@garenchan garenchan changed the base branch from master to 1.0-maintenance September 21, 2018 14:44
@garenchan garenchan changed the base branch from 1.0-maintenance to master September 21, 2018 14:46
@garenchan
Copy link
Contributor Author

@davidism, do you mean that document related PR should be based on the 1.0-maintenance branch?

@davidism
Copy link
Member

Yes

@garenchan garenchan closed this Sep 21, 2018
@garenchan garenchan reopened this Sep 21, 2018
@garenchan
Copy link
Contributor Author

There are some docs changes in the dev version that are also useful for 1.0-maintenance. If these commits aren't merged into 1.0-maintenance, the next change will be cumbersome.

@davidism
Copy link
Member

I know, I'm working on cherry picking them.

@garenchan
Copy link
Contributor Author

Thank you for your hard work!

@garenchan garenchan changed the title Docs: fix some errors in config.rst Docs: fix some typos in config.rst Sep 23, 2018
@davidism davidism added docs and removed docs labels Nov 13, 2018
@davidism davidism changed the base branch from master to 1.0-maintenance January 6, 2019 22:45
@davidism davidism merged commit 1e61669 into pallets:1.0-maintenance Jan 6, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants