Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moh 204 updates #1874

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Moh 204 updates #1874

merged 2 commits into from
Apr 29, 2024

Conversation

patryllus
Copy link

Screenshot from 2024-04-23 14-35-54

njorocs
njorocs approved these changes Apr 29, 2024
View reviewed changes
Copy link

@njorocs njorocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we bring these diagnosis to etl so that we don't have to query from different databases even if peformance overhead may be low coz the databases reside in the same box and there is no network latency?

@njorocs njorocs merged commit 65f8f3a into palladiumkenya:master Apr 29, 2024
@ojwanganto
Copy link

I support the ETL approach. Let's avoid connecting to concept and concept name during report generation. It will increase the time it takes to generate the report. @patryllus @njorocs please take note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njorocs njorocs njorocs approved these changes

@ojwanganto ojwanganto Awaiting requested review from ojwanganto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@patryllus @ojwanganto @njorocs