Add support for passing in request params via connect

[mlwilkerson]

My app uses request params to configure the ActionCable connection. This PR adds params as a key to connect so those params can be provided by the test code to test the connection. If there's an existing preferable way to do this with action-cable-testing I couldn't find it. I could also add a test for this params feature, but I couldn't seem to figure out how to get the tests to run in this repo. If someone could give me a hint as to how to get the development environment fully set up for running the tests in this repo, I could add testing for params.

[palkan]

Thanks for PR!

If there's an existing preferable way to do this with action-cable-testing I couldn't find it.

The way it can be achieved right now is the following:

connect "/cable?my_param=value"
# ...

Thus you can specify the connection URL (including params).

Having params: ... API makes sense to (this looks similar to request specs).

If someone could give me a hint as to how to get the development environment fully set up for running the tests in this repo, I could add testing for params.

Check out this PR on how you can add tests for the feature: #35

[mlwilkerson]

Oh wait, I see that I just needed to run rake as bundle exec rake to get all the environment stuff to work as expected for executing the tests.

I see the test failure in Travis CI. When I can come back to this, I'll dig into that failure, see if I can fix it, and then add a test for params.

[mlwilkerson]

Yes, I saw that I could pass in params via the GET url. But the particular thing I'm passing in here is a token as part of an authentication mechanism and I prefer to keep that out of the URL.

[palkan]

I prefer to keep that out of the URL

And how do you to pass it then? I mean, in your app?

[mlwilkerson]

I'm using graphql-ruby which uses ActionCable for the GraphQL subscriptions. There's a connectionParams object that can be optionally provided to the ActionCableLink object (which connects the GraphQL stuff to the ActionCable stuff). That connectionParams gets passed through to subscriptions.create().

[mlwilkerson]

Hang on, I think I'm confused with too many cobwebs in my mind from the holiday break.

I think that connectionParams feature only provides the params to the Channel on the sever side. I did end up having to use GET params to pass in the token that the Connection reads.

So this whole PR is maybe just a big exercise in forgetfulness on my part.

I just re-read some of my own comments about how I've been going about this which has jogged my memory.

Sorry for the spam here.

[palkan]

Thanks for the clarification.

I've added params: ... support in the Rails version (not yet merged rails/rails#34845).

I'll backport all the changes from Rails master to the gem as soon as the first Rails 6 RC will be released.