Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[popover2] docs(Tooltip2): add warning about disabled Buttons #5737

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

starcin
Copy link
Contributor

@starcin starcin commented Nov 9, 2022

Added the Button warning from deprecated Tooltip document

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

The documentation of the old Tooltip component has a warning about using the tooltip with Button component. The new document doesn't have this and it may confuse the users. I just copied that part.

Reviewers should focus on:

The warning in the Props section

Added the Button warning from deprecated Tooltip document
@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @starcin! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @starcin!

@adidahiya adidahiya changed the title Added the Button warning [popover2] docs(Tooltip2): add warning about disabled Buttons Nov 9, 2022
@adidahiya adidahiya merged commit 531c563 into palantir:develop Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants