Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No minimum version on HDF5 libraries #58

Open
pmelsted opened this issue Jun 16, 2015 · 1 comment
Open

No minimum version on HDF5 libraries #58

pmelsted opened this issue Jun 16, 2015 · 1 comment
Assignees
Labels

Comments

@pmelsted
Copy link
Contributor

HDF5 libraries version 1.8.4 has different API than what kallisto expects.

From cmake
-- Found HDF5: /usr/lib/libhdf5.so (found version "1.8.4")

after make
/home/vagrant/kallisto/src/h5utils.h:122:64: error: too many arguments to function 'hid_t H5Dopen1(hid_t, const char*)'
dataset_id = H5Dopen(group_id, dset_name.c_str(), H5P_DEFAULT);

@pimentel pimentel self-assigned this Jun 16, 2015
@pimentel
Copy link
Contributor

This is kind of messed up. It's very clear that the API has changed, though I can't pin down when it changed. Here is a bit of the version history:

https://www.hdfgroup.org/HDF5/doc/ADGuide/Changes_1_8_x.html
https://www.hdfgroup.org/HDF5/doc/TechNotes/Version.html

according to the version history this stuff was introduced in minor version 8, but it's unclear when the API started pointing to H5Dopen2 instead of H5Dopen1. This is going to take some digging into..

This will have to wait for the next version.

The other complication is the FindHDF5 CMake script that CMake ships with doesn't seem to offer support for version checking (seriously?) so we're going to have to figure out some work around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants