Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#249 Pac4jHandler not support DirectClient #256

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

ihostage
Copy link
Contributor

I tested only Java part on play-pac4j-java-demo. How it test on play-pac4j-scala-demo I don't know.
@leleuj can you help me to test Scala version?

@ihostage
Copy link
Contributor Author

On play-pac4j-java-demo for testing DirectBasicAuthClient I just change

@Secure(clients = "DirectBasicAuthClient,ParameterClient,DirectFormClient")
public Result dbaIndex() {

to

@SubjectPresent(handlerKey = "DirectBasicAuthClient", forceBeforeAuthCheck = true)
public Result dbaIndex() {

@leleuj
Copy link
Member

leleuj commented Jan 2, 2019

@ihostage I have never tested the Deadbolt Scala support. This was committed a year ago. @uqix : do you have any sample for testing a direct client? Thanks

@uqix
Copy link
Contributor

uqix commented Jan 2, 2019

@leleuj No, I don't have any sample for testing a direct client, just used it with indirect client once, since then I don't use Deadbolt any more, and it seems that it is so inactively maintained, instead I use play-pac4j authorization support.

@leleuj
Copy link
Member

leleuj commented Jan 2, 2019

@uqix Thanks for the feedback. Good choice! Indeed, Deadbolt does not seem to be very alive...

@ihostage Let's merge your changes as is. We'll see if someone pops up for the Deadbolt/pac4j Scala support.

@leleuj leleuj merged commit 889398d into pac4j:master Jan 2, 2019
@ihostage ihostage deleted the feature/249 branch January 2, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants