-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fails to form a complete Korean letter inside search bar #476
Comments
I don't use Korean so it's hard for me to debug, can you please provide as detailed as possible steps to reproduce the bug? |
Korean Input Method's layout is no different to Standard English layout. In order to input 강물, press r-k-d-a-n-f, you can try it somewhere else to see for yourself. |
I can reproduce the issue and know why it happens, not sure how to fix yet. |
Can you elaborate on why it's happening? also potential ideas on fixing if you have one. Modifying I'm out of ideas right now. |
I think the reason it's happening is because the search field loses focus after every character. This focus loss needs to happen because Maccy needs to give it to the history menu items so that the user could press Enter to select an item or arrow keys to navigate the menu. I believe we might try to throttle this behavior so that the focus is kept for a short period of time. This would at least improve the situation for fast typing. However, I am yet to find any docs about this behavior - maybe there is a hint somewhere there. |
For the time being, I've pushed a small workaround that fixes this as long as the search is not fired (400 ms). There should probably be a better solution (e.g. we call some AppKit API to evaluate the string of characters and replace them) but I am yet to find it. |
Whenever we call becomeFirstResponder() on the search field, it breaks Korean input handling where typing "rkadnf" should end up with "강물". Ideally we'd just call some method to re-evaluate the string in the search field and replace with proper characters, but I have not found a way to do that yet.
I didn't manage to find a reliable solution, please try using 0.25 and re-open if it's still not good enough. Hopefully, I can then make it better over time. |
Issue
Every keystroke is separated when typing Korean
For example, 강 comprised with ㄱ + ㅏ + ㅇ in correct order.
One thing to notice is that unlike chinese or japanese its combined on-the-fly. (in other words there's no IME overlay menu involved)
However, search bar only takes ㄱㅏㅇ(3 separated symbol) and not 강.
Copy & pasting works, I just can't type a complete word.
The text was updated successfully, but these errors were encountered: