[Cleanup] Merging PMachine with StateMachine #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ChristineZh0u
commented
Sep 5, 2024
- Removed InitializeParametersFunction(), class InitializeParameters, and class InitializeParametersEvent
- Removed most Try..() functions
- Made sure all unit test passes and generated logs are correct
ankushdesai
requested changes
Sep 5, 2024
| id = new StateMachineId(type, name, this); | ||
| if (name != null) | ||
| { | ||
| id = new StateMachineId(type, name.Substring(2), this); |
There was a problem hiding this comment.
This is because the new state machine's InterfaceName couldn't be passed in through InitializeParametersEvent anymore. I decided to pass it in is through the name parameters in CreateStateMachine() since it's not used for anything else. This function is originally getting called like this:
var machineId = CreateStateMachine(createMachine, createdInterface.Substring(2), new InitializeParametersEvent(new InitializeParameters(createdInterface, payload)));
Now it gets called like this:
var machineId = CreateStateMachine(createMachine, createdInterface, GetConstructorEvent(payload));
2cab15f
to
3fc6eec
Compare
3fc6eec
to
00f65cb
Compare
ankushdesai
approved these changes
Sep 5, 2024
ankushdesai
added a commit
that referenced
this pull request
Oct 10, 2024
* Doing a major clean up to simplify the code * Removed the unwanted changes in Actors * Removed push transitions and cleaned up the state machine code. * Fixed a minor bug in previous commit * Merging Actor.cs with StateMachine.cs (#757) fixing actor comment fixing Co-authored-by: Christine Zhou <[email protected]> Co-authored-by: Ankush Desai <[email protected]> * [Cleanup] Moving ActorRuntime into ControlledRuntime (#760) * [Cleanup] Moving ActorRuntime into ControlledRuntime * Changing all references of actor to state machine --------- Co-authored-by: Christine Zhou <[email protected]> * [Cleanup] Moving PJsonFormatter to PCheckerLogJsonFormatter and moving PLogFormatter to PCheckerLogTextFormatter (#763) Co-authored-by: Christine Zhou <[email protected]> * [Cleanup] Merging PEvent with Event (#764) Co-authored-by: Christine Zhou <[email protected]> * [Cleanup] Merging PMonitor with Monitor (#766) Co-authored-by: Christine Zhou <[email protected]> * Fixed the code for RaiseStmt * Adding test cases for 'raise' and 'goto' with payload (#767) Co-authored-by: Christine Zhou <[email protected]> * [Cleanup] Merging PMachine with StateMachine (#770) Co-authored-by: Christine Zhou <[email protected]> * Remove GodMachine, CoyoteRuntime; Fix Raise statement in Monitor (#772) * [Cleanup] Remove GodMachine, reformat PChecker folder, add assert false after raise test case * [Cleanup] Remove IStateMachineRuntime, ICyoteRuntime, CyoteRuntime * [Cleanup] Fixing monitor Raise statement + unit tests --------- Co-authored-by: Christine Zhou <[email protected]> * [Cleanup] Minor cleanups (#773) Organized exceptions files; removed dgml file generation; remove Guid; changed Prt naming files and values to P; Remove Coyote references from comments Co-authored-by: Christine Zhou <[email protected]> * [Cleanup] Remove statemachine factory, runtime factory, and name resolver (#774) Co-authored-by: Christine Zhou <[email protected]> * merging cleanup branch to master branch * Added a type checking rule for the Main Machine * Did some more cleanup; the test cases are failing right now. * Fixing warnings and errors --------- Co-authored-by: Ankush Desai <[email protected]> Co-authored-by: Christine Zhou <[email protected]> Co-authored-by: Ankush Desai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.