Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OZ-476: Added ShutdownHandler #33

Merged
merged 11 commits into from
May 29, 2024
Merged

OZ-476: Added ShutdownHandler #33

merged 11 commits into from
May 29, 2024

Conversation

VaishSiddharth
Copy link
Contributor

@VaishSiddharth VaishSiddharth commented May 7, 2024 •
edited
Loading

Added ShutdownHandler which will be triggered from generate-demo-data-route after the data is generated. It will shutdown the server.

JIRA: https://mekomsolutions.atlassian.net/browse/OZ-476

@VaishSiddharth VaishSiddharth changed the title OZ-476 | Expose Shutdown endpoint OZ-476: Added Shutdown bean May 13, 2024
@VaishSiddharth VaishSiddharth mentioned this pull request May 13, 2024
Merged
mks-d
mks-d reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@mks-d mks-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VaishSiddharth please update the PR desc. to reflect the latest state of things.

@mks-d mks-d changed the title OZ-476: Added Shutdown bean OZ-476: Added ShutdownHandler bean. May 14, 2024
corneliouzbett
corneliouzbett approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@corneliouzbett corneliouzbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would get rid of Utils class, add the logic to ShutdownHandler. Otherwise this LGTM!

Ruhanga
Ruhanga reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@Ruhanga Ruhanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add some unit tests @VaishSiddharth?

commons/src/main/java/com/ozonehis/eip/utils/Utils.java Outdated Show resolved Hide resolved
@VaishSiddharth VaishSiddharth changed the title OZ-476: Added ShutdownHandler bean. OZ-476: Added ShutdownHandler May 22, 2024
corneliouzbett
corneliouzbett approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@corneliouzbett corneliouzbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @VaishSiddharth

@corneliouzbett corneliouzbett merged commit dd77b72 into main May 29, 2024
4 checks passed
@corneliouzbett corneliouzbett deleted the oz-476 branch May 29, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mks-d mks-d mks-d left review comments

@Ruhanga Ruhanga Ruhanga left review comments

@ibacher ibacher ibacher left review comments

@corneliouzbett corneliouzbett corneliouzbett approved these changes

@rbuisson rbuisson Awaiting requested review from rbuisson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@VaishSiddharth @mks-d @corneliouzbett @Ruhanga @ibacher