-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(coverage): add Test262 semantic tests #4454
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #4454 will not alter performanceComparing Summary
|
We copied a lot of tests from |
Despite #3990, I do still think testing scopes against Test262 too is probably a good idea, for 2 reasons:
How far off were you from getting this working @DonIsaac? |
@overlookmotel the test infra works, but the tests need review. Not sure how to continue. @Dunqing thoughts? |
I agreed to continue this work. But It's not just test262. we also need to check that the semantics in the |
I'm going to work on this in #4790 |
What This PR Does
Adds a suite of
Semantic
tests that can be plugged in to existing coverage suites.The tests seem to run correctly, but now all parser Test262 tests are failing...