Decouple self-dependencies and impl lib.mkRustBin interface
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not part of our public interfaces and must not be imported alone.
Clean up entangled self-references and make inputs explicit through arguments.
This allows construction of `rust-bin` attrset on an existing `pkgs`, instead of staging another overlayed nixpkgs. This can reduce redundant evaluation of nixpkgs for flake-heavy users who also don't like or cannot (due to flake dependency hell) manually instantiate nixpkgs.
oxalica
force-pushed
the
feat/mk-rust-bin
branch
2 times, most recently
from
27f76c9
to
1611add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try 2 of previously reverted PR #124
mkRustBin (pkgs // { stdenv = ..; })mkRustBin pkgs.pkgsCross.aarch64-multiplatform. Examples are also added.