Changes for 4.0 to render content properly #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EParzefall
approved these changes
Aug 4, 2023
phil-davis
approved these changes
Aug 4, 2023
mmattel
force-pushed
the
3.1_necessary_adaptions
branch
from
e0b7cae
to
6bf19b0
Compare
mmattel
changed the title
mmattel
force-pushed
the
3.1_necessary_adaptions
branch
2 times, most recently
from
ae8aa8c
to
08481e8
Compare
mmattel
force-pushed
the
3.1_necessary_adaptions
branch
from
08481e8
to
f2d3904
Compare
phil-davis
reviewed
Aug 28, 2023
Co-authored-by: Phil Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: #576 (ocis 3.1 upgrade) and #593 (Make the version 4.0.0 instead of 3.1)
These are the changes necessary to render 4.0 properly.
With the referenced PR, the upgrade procedure has been merged already.
Note that though
docs-stable-4.0is already set inantora.yml, it does currently not exist in the ocis repo. When testing, you will therefore get not all content rendered properly.Merge only after testing when the necessary ocis doc branch has been created.
Important, the Helm Chart part is NOT covered here and must be done in a separate PR.
@micbar fyi