Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI update workflow #80

Merged
merged 7 commits into from
Feb 15, 2023
Merged

CI update workflow #80

merged 7 commits into from
Feb 15, 2023

Conversation

maikia
Copy link
Collaborator

@maikia maikia commented Feb 15, 2023

update workflow to run pre-commit to avoid redundant code (in workflow and in precommit)

Reference Issue or PRs

when adding mypy to pre-commit, CI should automatically run it as well #68

What does your PR implement? Be specific.

It removes the checking of the linting from the workflow and instead it runs pre-commit which has those checks included

@maikia maikia changed the title update workflow CI update workflow Feb 15, 2023
@maikia maikia marked this pull request as ready for review February 15, 2023 09:52
Copy link
Collaborator

@BorisMuzellec BorisMuzellec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @maikia!

@BorisMuzellec BorisMuzellec merged commit 1f3e00c into main Feb 15, 2023
@BorisMuzellec BorisMuzellec deleted the workflow branch February 15, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants