Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG set dds.replaced to False if cohorts don't have enough samples #70

Merged
merged 3 commits into from
Feb 13, 2023
Merged

BUG set dds.replaced to False if cohorts don't have enough samples #70

merged 3 commits into from
Feb 13, 2023

Conversation

BorisMuzellec
Copy link
Collaborator

@BorisMuzellec BorisMuzellec commented Feb 3, 2023 •
edited
Loading

Reference Issue or PRs

Fixes #69.

What does your PR implement? Be specific.

@BorisMuzellec BorisMuzellec marked this pull request as ready for review February 3, 2023 11:37
@BorisMuzellec BorisMuzellec changed the title Fix refit samples BUG set replaced to False if cohorts don't have enough samples Feb 3, 2023
@BorisMuzellec BorisMuzellec changed the title BUG set replaced to False if cohorts don't have enough samples BUG set dds.replaced to False if cohorts don't have enough samples Feb 3, 2023
@ghost ghost added the bug Something isn't working label Feb 10, 2023
@BorisMuzellec BorisMuzellec merged commit 288bdae into main Feb 13, 2023
@BorisMuzellec BorisMuzellec deleted the fix_refit_samples branch February 13, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maikia maikia Awaiting requested review from maikia maikia is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] DeseqDataSet._replace_outliers ignores whether cohorts have enough samples
1 participant
@BorisMuzellec