Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modelgen: Don't append package to output directory #91

Merged
merged 1 commit into from
May 11, 2021

Conversation

dave-tucker
Copy link
Collaborator

This allows for modelgen to be used by go generate,
where a package would have a skeleton gen.go file and
modelgen would place all generated files in that directory.

The -o flag can be used to reinstate the original behaviour.
E.g -p foo -o foo.

Signed-off-by: Dave Tucker [email protected]

This allows for modelgen to be used by `go generate`,
where a package would have a skeleton `gen.go` file and
modelgen would place all generated files in that directory.

The -o flag can be used to reinstate the original behaviour.
E.g -p foo -o foo.

Signed-off-by: Dave Tucker <[email protected]>
@dave-tucker dave-tucker requested a review from amorenoz May 11, 2021 10:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 831266918

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.613%

Totals Coverage Status
Change from base Build 831178161: 0.0%
Covered Lines: 1349
Relevant Lines: 1808

💛 - Coveralls

@amorenoz
Copy link
Collaborator

LGTM

@dave-tucker dave-tucker merged commit 0188574 into ovn-org:main May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants