-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organize project #88
Conversation
This moves all ovsdb notation to it's own package As such, everything ovsdb related (including changing ovsdb types to go types) resides in `ovsdb`. ALl client-specific code remains in the `libovsdb` package Signed-off-by: Dave Tucker <[email protected]>
Pull Request Test Coverage Report for Build 831148708
💛 - Coveralls |
I haven't taken a deep look but sharing a couple of initial thoughts:
vs
|
They are more than examples, and are actually useful utilities. As such, they belong in cmd Signed-off-by: Dave Tucker <[email protected]>
go-staticcheck likes all error messages to be lowercase Signed-off-by: Dave Tucker <[email protected]>
Signed-off-by: Dave Tucker <[email protected]>
Signed-off-by: Dave Tucker <[email protected]>
@amorenoz based on our chat yesterday I've updated this. |
@dave-tucker LGTM, only comment is, if we ever want to have another module (e.g: |
@amorenoz good point. I'll merge this as-is, and we can look at splitting out the orm layer in to it's own package later. |
ovsdb
. this provides a clean separation betweena) marshalling/unmarshalling of ovsdb datatypes and mapping to go types
b) client code (e.g cache, orm, api etc...)
examples/stress
andexamples/print_schema
tocmd
as they are useful commands (more than examples)gopls
insists on).golangci.yml
to attempt to replicate ^ but doesn't quite yet - i need to investigate this more thoroughly