Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adapt to Figma's New Link Structure for Embedding Design Previews #6946

Merged
merged 1 commit into from
May 26, 2024

Conversation

RenderCoder
Copy link
Contributor

Description

Recently, Figma updated their link structure, changing the shareable links for design files from www.figma.com/file to www.figma.com/design. This change breaks the functionality that allows designers to embed Figma design previews in documents.

This PR addresses and resolves this issue, ensuring that the new Figma links are correctly parsed and embedded.

Changes

  • Updated the link parsing logic to support the new Figma file paths.
  • Ensured backward compatibility with the old www.figma.com/file links.

How to Test

  1. Insert a Figma link with the new www.figma.com/design format into a supported document.
  2. Verify that the Figma design preview is correctly embedded.
  3. Repeat the test with an old www.figma.com/file link to ensure backward compatibility.

@auto-assign auto-assign bot requested a review from tommoor May 26, 2024 06:36
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


RenderCoder seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tommoor tommoor enabled auto-merge (squash) May 26, 2024 13:36
@RenderCoder
Copy link
Contributor Author

CLA has been signed.

@tommoor tommoor disabled auto-merge May 26, 2024 15:04
@tommoor tommoor merged commit 88eae87 into outline:main May 26, 2024
8 of 9 checks passed
@RenderCoder RenderCoder deleted the fix/figma-link-insert-issue branch May 26, 2024 15:11
moarsoarse pushed a commit to solvo-ru/outline that referenced this pull request May 27, 2024
truecharts-admin added a commit to truecharts/charts that referenced this pull request Jun 14, 2024
…97bcc by renovate (#23333)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [outlinewiki/outline](https://togithub.com/outline/outline) | minor |
`0.76.1` -> `0.77.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>outline/outline (outlinewiki/outline)</summary>

###
[`v0.77.0`](https://togithub.com/outline/outline/releases/tag/v0.77.0)

[Compare
Source](https://togithub.com/outline/outline/compare/v0.76.1...v0.77.0)

#### What's Changed

This release changes how documents are rendered, allowing the
introduction of new editor functionality and attributes. Highlighted for
this release are some big improvements to tables:


![image](https://togithub.com/outline/outline/assets/380914/6109e4a5-fc5a-4a25-ae33-eebbe9adc0db)

- **Column resizing:** You can now resize columns by dragging the border
between them
- **Full-width tables:** Tables now expand to the full width of the
editor
- **More content:** Table cells now support embeds, code blocks, and all
other content types
-   **Toggleable headers:** You can now toggle a header row and column
- **Improved overflow:** Tables now scroll horizontally when they're too
wide for the editor
- **Improved row and column controls**: We've made it one click to add
rows and columns

##### Other improvements

- Added more highlighter color choices in
[outline/outline#7012
- New collection permissions UI in
[outline/outline#6917
- Big rendering performance improvements for documents with many images
- Add `Manage` permission to documents allows other users to manage
sharing in
[outline/outline#7003
- Added an embedded Yandex Maps component by
[@&#8203;shashinma](https://togithub.com/shashinma) in
[outline/outline#6881
- Added a permission selector in document/collection invite flow in
[outline/outline#6948
- Added support for embedded youtube clips by
[@&#8203;Pranav2612000](https://togithub.com/Pranav2612000) in
[outline/outline#6942
- Matomo integration in
[outline/outline#7009
- `/` block insert shortcut now works anywhere on a line or table in
[outline/outline#7026
- Added the ability to remove a previously uploaded team logo or profile
picture
-   Added a menu option to create template directly in collection

##### Fixes

-   Various fixes to improve the fluidity of app loading
- Image placeholders are now correctly sized when uploading retina
images
- Images and PDF's are now served with inline content disposition in
[outline/outline#6924
- Added support for Figma's new link formats and Figjam boards by
[@&#8203;RenderCoder](https://togithub.com/RenderCoder) in
[outline/outline#6946
- `files.get` now supports range header, fixes video loading in Safari
in
[outline/outline#6950
- Fixed an issue where zoomed images could get stuck in
[outline/outline#6980
-   Share button was removed on templates
-   Fixed race condition that could result in document emoji not saving
-   Removed trust of `state.host` in auth error redirect
-   Collapsed sidebar now works better in Arc/Edge redesign

#### New Contributors

- [@&#8203;shashinma](https://togithub.com/shashinma) made their first
contribution in
[outline/outline#6881
- [@&#8203;lng2020](https://togithub.com/lng2020) made their first
contribution in
[outline/outline#6731
- [@&#8203;RenderCoder](https://togithub.com/RenderCoder) made their
first contribution in
[outline/outline#6946
- [@&#8203;Frzk](https://togithub.com/Frzk) made their first
contribution in
[outline/outline#6971
- [@&#8203;bkrausz](https://togithub.com/bkrausz) made their first
contribution in
[outline/outline#7022

**Full Changelog**:
outline/outline@v0.76.0...v0.77.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MDcuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQwNy40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Shuttleu pushed a commit to Shuttleu/outline that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants