update mm-sink tutorial and plot

[zoepiran]

Updates MM-OT tutorial visualization and adds MM-OT plotting utils.

Updates in files:

• docs/references.bib: add citation lin:22
• docs/tutorials/linear/600_mmsink.ipynb: update visuals and add comparison to MM (det. solution)
• src/ott/tools/plot.py: add class PlotMM

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

michalk8 commented on 2024-08-19T10:41:15Z
----------------------------------------------------------------

Line #1.    def plot_clouds(

With a bit of refactoring, I think we should be able to do

plott = plot.PlotMM(fig=fig, cmap=cmap)
_ = plott(out)

And then we could remove the helper plotting function above.

zoepiran commented on 2024-08-19T14:29:06Z
----------------------------------------------------------------

genious

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

michalk8 commented on 2024-08-19T10:41:15Z
----------------------------------------------------------------

Both are determisnistic, afaik.

zoepiran commented on 2024-08-19T14:29:19Z
----------------------------------------------------------------

horrible phrasing

[codecov]

Codecov Report

Attention: Patch coverage is 18.84058% with 56 lines in your changes missing coverage. Please review.

Project coverage is 87.76%. Comparing base (626aad6) to head (7cc366c).
Report is 2 commits behind head on main.

Files	Patch %	Lines
src/ott/tools/plot.py	18.84%	56 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
- Coverage   88.38%   87.76%   -0.62%     
==========================================
  Files          72       72              
  Lines        7724     7791      +67     
  Branches     1109     1124      +15     
==========================================
+ Hits         6827     6838      +11     
- Misses        746      802      +56     
  Partials      151      151              

Files	Coverage Δ
src/ott/tools/plot.py	54.09% <18.84%> (-21.77%)	⬇️

[zoepiran]

genious

---

View entire conversation on ReviewNB

[zoepiran]

horrible phrasing

---

View entire conversation on ReviewNB

[michalk8]

LGTM, will wait until the CI passes and then merge! Thanks @zoepiran !