Final Project Entropic maps BARRIERE PELTIER #360
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thanks! can you fix the linter issues? you can check first the CONTRIBUTING.md file and install Thanks! |
Applied pre-commit to your changes!
|
Dear Mister Cuturi, We apologise for the inconvenience. We have sorted out the problems with the commit and we applied pre-commit. Thank you in advance. Sincerely yours, |
|
I am very sorry, it seems that the remaining errors are due to spell checks. In particular, the names of individuals seem to be considered as spell errors. |
| @@ -0,0 +1,1562 @@ | |||
| { | |||
There was a problem hiding this comment.
typos:
"based on the results of presented in"
"We considere"
"given the two probability distributions P and Q," -> given two, P, Q should be written in markdown
REF
idea: is the idea really to let \varepsilon go to 0?
Reply via ReviewNB
| @@ -0,0 +1,1562 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #15. entropic_pot = potentials.EntropicPotentials(
this is easier by just instantiating ot_sink.to_dual_potentials
Reply via ReviewNB
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
=======================================
Coverage 88.20% 88.20%
=======================================
Files 51 51
Lines 5530 5530
Branches 831 831
=======================================
Hits 4878 4878
Misses 532 532
Partials 120 120 |
No description provided.