Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial for unbalanced OT #291

Merged
merged 20 commits into from
Aug 9, 2024
Merged

Add tutorial for unbalanced OT #291

merged 20 commits into from
Aug 9, 2024

Conversation

nvesseron
Copy link
Contributor

I added a tutorial for unbalanced OT and added a reference in the bib that I cite in the tutorial.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nina! this looks great. I also think this will need to be added in the rst files to show up in the docs. Maybe we need some hierarchy.

docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
@@ -0,0 +1,381 @@
{
Copy link
Contributor

@pierreablin pierreablin Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #12.    source = gaussian_mixture(

I think these should be renamed source -> x and target -> y to be more consistent with the other notebooks?


Reply via ReviewNB

docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
@michalk8
Copy link
Collaborator

Can you also please add the notebook to the documentation in the appropriate place here?

@marcocuturi
Copy link
Contributor

Hi Nina! any progress on your end for this notebook?

@nvesseron
Copy link
Contributor Author

nvesseron commented Mar 20, 2023 via email

@nvesseron
Copy link
Contributor Author

Thank you very much for your comments, it helped me a lot !

Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvesseron there seems to be rendering issue in the first cell, can you please fix it?
https://ott-jax--291.org.readthedocs.build/en/291/tutorials/notebooks/Unbalanced_OT.html

docs/references.bib Outdated Show resolved Hide resolved
docs/references.bib Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
docs/tutorials/notebooks/Unbalanced_OT.ipynb Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (2d616f4) to head (cf86d21).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files          72       72           
  Lines        7716     7716           
  Branches     1107     1107           
=======================================
  Hits         6822     6822           
  Misses        743      743           
  Partials      151      151           

@michalk8
Copy link
Collaborator

michalk8 commented Jun 5, 2024

@nvesseron can you tell me what's the status of this PR? I think it was almost done, am not sure whether the above comments have been addressed though.

@nvesseron
Copy link
Contributor Author

@michalk8 I did change the notebook according to your comments. Do not hesitate to tell me if there is anything else I can do to improve the notebook. Thank you for helping me with that contribution.

Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @nvesseron , thanks a lot!

I just fixed the Bibtex file + small typos, think we can merge soon!

Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks everyone!

@michalk8 michalk8 merged commit 77fd44a into ott-jax:main Aug 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants