State management for underlying AudioContext object #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the AudioContext object created by hark to be managed by a user of the library. In particular, useful for iOS WebRTC scenarios where the AudioContext stream must be started by a user action.
|
@latentflip I rebuilt and pushed v1.2.0 but I do not appear to have publish rights on npm for this module. Could you publish the latest and/or add me as an npm contributor, please? |
|
@xdumaine I've added you to npm 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the AudioContext object created by hark to be managed
by a user of the library. In particular, useful for iOS WebRTC scenarios
where the AudioContext stream must be started by a user action.
See https://bugs.webkit.org/show_bug.cgi?id=177292 for more info. Hopefully they'll remove this silly restriction for the WebRTC case in the future, but for now, it will make hark work for iOS.
Not sure if the API is what you want, let me know if you'd like it structured differently -- I just went with what the person in that thread gave me as a starting point.