Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KERNEL: Extract a service module for modules to use. #820

Closed
winlinvip opened this issue Mar 26, 2017 · 2 comments
Closed

KERNEL: Extract a service module for modules to use. #820

winlinvip opened this issue Mar 26, 2017 · 2 comments
Assignees
@winlinvip
Labels
Enhancement Improvement or enhancement. TransByAI Translated by AI/GPT.
Milestone
3.0

Comments

@winlinvip
Copy link
Member

winlinvip commented Mar 26, 2017 •
edited
Loading

Right now, there are some applications or library of SRS:

  1. Binary objs/srs, generated by core/kernel/protocol/app/main.
  2. Binary objs/srs_hls_ingester, generated by core/kernel/protocol/app/main. But, it's not compatible with config object, so it set the _srs_config to NULL. That's rediculous.
  3. Library objs/lib/srs_librtmp.a, generated by core/kernel/protocol.
  4. Binaries objs/research/library/*, generated by research and srs_librtmp.a.

SRS also support modules, for example, srs_hls_ingester is a module. For all SRS modules, the config object doesn't works well, because the config object is only for objs/srs. In another word, some objects are not available for modules, so we extract a service in src/service for modules.

Please refer to the arch https://github.com/ossrs/srs/tree/develop#modularity-architecture.
@winlinvip winlinvip added the Enhancement Improvement or enhancement. label Mar 26, 2017
@winlinvip winlinvip added this to the srs 3.0 release milestone Mar 26, 2017
winlinvip added a commit that referenced this issue Mar 26, 2017
@winlinvip
For #820, extract service module.
ff822b5
@winlinvip winlinvip mentioned this issue Mar 26, 2017
Closed
winlinvip added a commit that referenced this issue Mar 26, 2017
@winlinvip
For #820, modules use service only.
e3526c0
winlinvip added a commit that referenced this issue Mar 26, 2017
@winlinvip
For #820, fix utest failed.
7d618fe
winlinvip added a commit that referenced this issue Mar 26, 2017
@winlinvip
For #820, fix warnings
362b578
winlinvip added a commit that referenced this issue Mar 26, 2017
@winlinvip
For #820, fix ubuntu build failed.
b75a3fa
winlinvip added a commit that referenced this issue Mar 26, 2017
@winlinvip
Fix #820, extract service for modules. 3.0.21
609605a
@winlinvip
Copy link
Member Author

Fixed.

@winlinvip
Copy link
Member Author

winlinvip commented Sep 17, 2021 •
edited
Loading

The 'Service module' was merged into the 'protocol' after SRS 3.

TRANS_BY_GPT3

@winlinvip winlinvip self-assigned this Sep 17, 2021
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winlinvip winlinvip

Labels
Enhancement Improvement or enhancement. TransByAI Translated by AI/GPT.
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@winlinvip