allow generic string as metric name #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
noamokman
commented
Jul 9, 2022
- allow generic string as metric name
- .
| @@ -115,11 +115,15 @@ const innerMonitor = <Callable, Scope extends string, Method extends string>({ | |||
|
|
|||
| export const createMonitor = | |||
| <Scope extends string>({ scope, ...initOptions }: InitOptions<Scope>) => | |||
| <Callable, Method extends string>(method: CamelCase<Method>, callable: () => Callable, options?: MonitorOptions<Callable>) => | |||
| <Callable, Method extends string>( | |||
| method: CamelCase<Method> extends never ? string : CamelCase<Method>, | |||
There was a problem hiding this comment.
extends never ? : string
mind explaning?
CamelCase didn't let you put a variable as a scope / method name?
There was a problem hiding this comment.
Yeah, it resolves to never, so this is the workaround
There was a problem hiding this comment.
Also, look at the test I added, it failed before
SharonGrossman
approved these changes
Jul 9, 2022
|
package.json version bump |
|
@SharonGrossman thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.