🐛 fix and result of multicheck #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <[email protected]>
2 tasks
laurentsimon
approved these changes
Jun 11, 2021
azeemshaikh38
approved these changes
Jun 11, 2021
Signed-off-by: Asra Ali <[email protected]>
auto-merge was automatically disabled
June 14, 2021 14:17
Head branch was pushed to by a user without write access
laurentsimon
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali [email protected]
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes MultiCheckAnd logic. If there is a failing result with confidence 7 and another with 10, multicheck and should return the worst, as in, the 10.
What is the current behavior? (You can also link to an open issue here)
MultiCheckAnd will return the least confident of failing results.
What is the new behavior (if this is a feature change)?
MultiCheckAnd will return the most confident of failing results.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: