-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enable dangerous workflow in release test #1402
✨ Enable dangerous workflow in release test #1402
Conversation
Signed-off-by: Asra Ali <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! How does this enable it though? I thought this env var only blocks CLI from running Dangerous-Workflow?
Shoot, I took a second to trace through and I'm confused why it's not in there. scorecard/cron/k8s/worker.release.yaml Line 43 in 65eddea
doesn't include DangerousWorkflow so checksToRun should contain that ( Line 209 in 08a7876
|
I just found the bug - the env var is misspelled - https://github.com/ossf/scorecard/blob/main/cron/k8s/worker.release.yaml#L42. I'm an idiot. Could you please fix that in this PR? |
Signed-off-by: Asra Ali <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Integration tests success for |
Signed-off-by: Asra Ali [email protected]
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Enables Dangerous-Workflow in release test
What is the current behavior? (You can also link to an open issue here)
Part of Feature: Rollout the Dangerous-Workflow check #1399
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: