Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enable dangerous workflow in release test #1402

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Dec 16, 2021

Signed-off-by: Asra Ali [email protected]

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Enables Dangerous-Workflow in release test

  • What is the current behavior? (You can also link to an open issue here)
    Part of Feature: Rollout the Dangerous-Workflow check #1399

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! How does this enable it though? I thought this env var only blocks CLI from running Dangerous-Workflow?

@asraa
Copy link
Contributor Author

asraa commented Dec 16, 2021

Thanks! How does this enable it though? I thought this env var only blocks CLI from running Dangerous-Workflow?

Shoot, I took a second to trace through and I'm confused why it's not in there.

value: "SAST,CI-Tests,Contributors"

doesn't include DangerousWorkflow so checksToRun should contain that (
checksToRun := checks.AllChecks
)...

@azeemshaikh38
Copy link
Contributor

Shoot, I took a second to trace through and I'm confused why it's not in there.

I just found the bug - the env var is misspelled - https://github.com/ossf/scorecard/blob/main/cron/k8s/worker.release.yaml#L42. I'm an idiot. Could you please fix that in this PR?

Signed-off-by: Asra Ali <[email protected]>
Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test December 16, 2021 18:26 Inactive
@github-actions
Copy link

Integration tests success for
[7ea87a6]
(https://github.com/ossf/scorecard/actions/runs/1588878947)

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) December 16, 2021 18:32
@azeemshaikh38 azeemshaikh38 merged commit c795615 into ossf:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants