Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 update dangerous workflow to use actionlint #1328

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Nov 22, 2021

Signed-off-by: Asra Ali [email protected]

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • refactors dangerous-workflow to use the actionlint library

  • What is the current behavior? (You can also link to an open issue here)
    Part of BUG: Parsing errors #839

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:
    cc @chrismcgehee

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fix the potential nil ptr accesses.

checks/dangerous_workflow.go Outdated Show resolved Hide resolved
checks/dangerous_workflow.go Show resolved Hide resolved
checks/dangerous_workflow.go Show resolved Hide resolved
Signed-off-by: Asra Ali <[email protected]>
@asraa asraa temporarily deployed to integration-test November 22, 2021 18:08 Inactive
@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) November 22, 2021 18:30
@github-actions
Copy link

Integration tests success for
[ce75e14]
(https://github.com/ossf/scorecard/actions/runs/1491514333)

@azeemshaikh38 azeemshaikh38 merged commit fd67ddf into ossf:main Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants