Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add email confirmation for registration #59

Merged
merged 3 commits into from
Jul 27, 2019

Conversation

bvishal8510
Copy link
Contributor

Solves issue #30 . @NeuralFlux please review.

@pep8speaks
Copy link

pep8speaks commented Jul 23, 2019

Hello @bvishal8510! Thanks for updating this PR.

Line 13:101: E501 line too long (102 > 100 characters)
Line 14:10: E128 continuation line under-indented for visual indent

Comment last updated at 2019-07-27 06:03:27 UTC

@svp19 svp19 self-requested a review July 25, 2019 16:03
Copy link
Member

@svp19 svp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvishal8510

  • Do change the subject from Activate your Phoics account to Activate your activate Crispy AI account.
  • Also, I got a WARNING while running python manage.py migrate
WARNINGS:                                                                                                                                                                    
?: (2_0.W001) Your URL pattern '^activate/(?P<uidb64>[0-9A-Za-z_\-]+)/(?P<token>[0-9A-Za-z]{1,13}-[0-9A-Za-z]{1,20})/$' [name='activate'] has a route that contains '(?P<', b
egins with a '^', or ends with a '$'. This was likely an oversight when migrating to django.urls.path().

FIX
This is because path() in Django 2.0 doesn't use regular expressions. Use re_path() instead.

See more https://stackoverflow.com/questions/47661536/django-2-0-path-error-2-0-w001-has-a-route-that-contains-p-begins-wit

~ The rest works as expected :)

@bvishal8510
Copy link
Contributor Author

@svp19 please review the changes.

@svp19 svp19 merged commit 63c5eb9 into oss2019:master Jul 27, 2019
@svp19 svp19 added the SoI19 label Jul 28, 2019
@svp19 svp19 added this to In progress in Crispy AI Project Board via automation Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Crispy AI Project Board
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants